Fix CHASM not found errors #8697
Open
+29
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dandavison
force-pushed
the
chasm-not-found
branch
4 times, most recently
from
803132d to
5f35b19
Compare
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
dandavison
force-pushed
the
chasm-not-found
branch
from
5f35b19 to
c02270c
Compare
dandavison
force-pushed
the
chasm-not-found
branch
from
c02270c to
42a1a84
Compare
| var notFound *serviceerror.NotFound | ||
| if errors.As(err, ¬Found) { | ||
| err = serviceerror.NewNotFound("execution not found") | ||
| } |
There was a problem hiding this comment.
Bug: Blanket NotFound replacement masks semantic errors
The fix replaces ALL NotFound errors with "execution not found" without checking the original error message or type. This could incorrectly mask other semantically distinct NotFound errors like ErrStaleReference ("stale reference") if the consistency predicate check returns such errors. The fix should only replace the specific "workflow execution not found" message, or handle staleReferenceErr separately to prevent masking reference staleness errors.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently read/update requests for CHASM executions are returning "workflow execution not found" as the
NotFounderror message. This PR fixes the message. It didn't look likeArchetypeexposes a string suitable for use here so I didn't try to do that.Note
Maps backend NotFound to "execution not found" for missing CHASM executions and adds a unit test to validate it.
getExecutionLease(inservice/history/chasm_engine.go) toserviceerror.NewNotFound("execution not found").TestReadComponent_NotFoundinservice/history/chasm_engine_test.goto assert the standardized error message and ensurereadFnis not invoked.Written by Cursor Bugbot for commit 42a1a84. This will update automatically on new commits. Configure here.